ENT-13879: Checks variadic functions for valid number of arguments in call#74
Merged
olehermanse merged 4 commits intocfengine:mainfrom Apr 24, 2026
Merged
Conversation
Contributor
Author
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
cc6e6f5 to
94773a7
Compare
Member
|
@SimonThalvorsen Other PR was merged, you can rebase now :) |
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
2f358a3 to
0373c71
Compare
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
0373c71 to
1a1715d
Compare
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
1a1715d to
438e4ee
Compare
olehermanse
requested changes
Apr 22, 2026
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Looks good but let's focus on the core PR first, will need to adjust this one afterwards.
larsewi
approved these changes
Apr 23, 2026
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
438e4ee to
cab2c7e
Compare
olehermanse
requested changes
Apr 24, 2026
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Looks good, just some readability suggestions, and needs to be adapted for optional maxArgs.
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
cab2c7e to
c0d43e7
Compare
… call Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
c0d43e7 to
2a62a56
Compare
olehermanse
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.